Add tests for ObjectiveBound (#446)

* Add tests for ObjectiveBound

* Clean up some nits.

Author: odow

src/Test/UnitTests/solve.jl

@@ -0,0 +1,81 @@
+"""
+    solve_objbound_edge_cases(model::MOI.ModelLike, config::TestConfig)
+
+Test a variety of edge cases related to the ObjectiveBound attribute.
+"""
+function solve_objbound_edge_cases(model::MOI.ModelLike, config::TestConfig)
+    @testset "Min IP with constant" begin
+        MOI.empty!(model)
+        @test MOI.isempty(model)
+        MOIU.loadfromstring!(model, """
+            variables: x
+            minobjective: 2.0x + -1.0
+            c1: x >= 1.5
+            c2: x in Integer()
+        """)
+        x = MOI.get(model, MOI.VariableIndex, "x")
+        test_model_solution(model, config;
+            objective_value = 3.0,
+            variable_primal = [(x, 2.0)]
+        )
+        if config.solve
+            @test MOI.get(model, MOI.ObjectiveBound()) <= 3.0
+        end
+    end
+
+    @testset "Max IP with constant" begin
+        MOI.empty!(model)
+        @test MOI.isempty(model)
+        MOIU.loadfromstring!(model, """
+            variables: x
+            maxobjective: 2.0x + 1.0
+            c1: x <= 1.5
+            c2: x in Integer()
+        """)
+        x = MOI.get(model, MOI.VariableIndex, "x")
+        test_model_solution(model, config;
+            objective_value = 3.0,
+            variable_primal = [(x, 1.0)]
+        )
+        if config.solve
+            @test MOI.get(model, MOI.ObjectiveBound()) >= 3.0
+        end
+    end
+
+    @testset "Min LP with constant" begin
+        MOI.empty!(model)
+        @test MOI.isempty(model)
+        MOIU.loadfromstring!(model, """
+            variables: x
+            minobjective: 2.0x + -1.0
+            c1: x >= 1.5
+        """)
+        x = MOI.get(model, MOI.VariableIndex, "x")
+        test_model_solution(model, config;
+            objective_value = 2.0,
+            variable_primal = [(x, 1.5)]
+        )
+        if config.solve
+            @test MOI.get(model, MOI.ObjectiveBound()) <= 2.0
+        end
+    end
+
+    @testset "Max LP with constant" begin
+        MOI.empty!(model)
+        @test MOI.isempty(model)
+        MOIU.loadfromstring!(model, """
+            variables: x
+            maxobjective: 2.0x + 1.0
+            c1: x <= 1.5
+        """)
+        x = MOI.get(model, MOI.VariableIndex, "x")
+        test_model_solution(model, config;
+            objective_value = 4.0,
+            variable_primal = [(x, 1.5)]
+        )
+        if config.solve
+            @test MOI.get(model, MOI.ObjectiveBound()) >= 4.0
+        end
+    end
+end
+unittests["solve_objbound_edge_cases"] = solve_objbound_edge_cases

src/Test/UnitTests/unit_tests.jl

@@ -98,5 +98,6 @@ include("objectives.jl")
 include("constraints.jl")
 include("basic_constraint_tests.jl")
 include("modifications.jl")
+include("solve.jl")
 
 @moitestset unit

src/Utilities/mockoptimizer.jl

@@ -28,6 +28,7 @@ mutable struct MockOptimizer{MT<:MOI.ModelLike} <: MOI.AbstractOptimizer
     resultcount::Int
     evalobjective::Bool # Computes ObjectiveValue by evaluation ObjectiveFunction with VariablePrimal
     objectivevalue::Float64
+    objectivebound::Float64  # set this using MOI.set!(model, MOI.ObjectiveBound(), value)
     primalstatus::MOI.ResultStatusCode
     dualstatus::MOI.ResultStatusCode
     varprimal::Dict{MOI.VariableIndex,Float64}
@@ -57,6 +58,7 @@ MockOptimizer(inner_model::MOI.ModelLike; needsallocateload=false, evalobjective
                   0,
                   evalobjective,
                   NaN,
+                  NaN,
                   MOI.UnknownResultStatus,
                   MOI.UnknownResultStatus,
                   Dict{MOI.VariableIndex,Float64}(),
@@ -180,6 +182,13 @@ MOI.get(mock::MockOptimizer, attr::MOI.AbstractConstraintAttribute, idx::MOI.Con
 MOI.get(mock::MockOptimizer, ::MOI.ConstraintDual, idx::MOI.ConstraintIndex) = mock.condual[xor_index(idx)]
 MOI.get(mock::MockOptimizer, ::MockConstraintAttribute, idx::MOI.ConstraintIndex) = mock.conattribute[xor_index(idx)]
 
+MOI.supports(mock::MockOptimizer, ::MOI.ObjectiveBound) = true
+MOI.canget(mock::MockOptimizer, ::MOI.ObjectiveBound) = !isnan(mock.objectivebound)
+MOI.get(mock::MockOptimizer, ::MOI.ObjectiveBound) = mock.objectivebound
+function MOI.set!(mock::MockOptimizer, ::MOI.ObjectiveBound, value::Float64)
+    mock.objectivebound = value
+end
+
 function MOI.empty!(mock::MockOptimizer)
     MOI.empty!(mock.inner_model)
     mock.attribute = 0
@@ -191,6 +200,7 @@ function MOI.empty!(mock::MockOptimizer)
     mock.terminationstatus = MOI.Success
     mock.resultcount = 0
     mock.objectivevalue = NaN
+    mock.objectivebound = NaN
     mock.primalstatus = MOI.UnknownResultStatus
     mock.dualstatus = MOI.UnknownResultStatus
     mock.varprimal = Dict{MOI.VariableIndex,Float64}()
@@ -206,6 +216,7 @@ function MOI.isempty(mock::MockOptimizer)
         !mock.solved && !mock.hasprimal && !mock.hasdual &&
         mock.terminationstatus == MOI.Success &&
         mock.resultcount == 0 && isnan(mock.objectivevalue) &&
+        isnan(mock.objectivebound) &&
         mock.primalstatus == MOI.UnknownResultStatus &&
         mock.dualstatus == MOI.UnknownResultStatus
 end

test/Test/unit.jl

@@ -21,7 +21,8 @@ end
         "solve_qcp_edge_cases",
         "solve_affine_deletion_edge_cases",
         "solve_duplicate_terms_obj",
-        "solve_integer_edge_cases"
+        "solve_integer_edge_cases",
+        "solve_objbound_edge_cases"
         ])
 
     @testset "solve_blank_obj" begin
@@ -209,6 +210,28 @@ end
         )
         MOIT.solve_integer_edge_cases(mock, config)
     end
+    @testset "solve_objbound_edge_cases" begin
+        MOIU.set_mock_optimize!(mock,
+            (mock::MOIU.MockOptimizer) -> begin
+                MOI.set!(mock, MOI.ObjectiveBound(), 3.0)
+                MOIU.mock_optimize!(mock, MOI.Success, (MOI.FeasiblePoint, [2.0]))
+            end,
+            (mock::MOIU.MockOptimizer) -> begin
+                MOI.set!(mock, MOI.ObjectiveBound(), 3.0)
+                MOIU.mock_optimize!(mock, MOI.Success, (MOI.FeasiblePoint, [1.0]))
+            end,
+            (mock::MOIU.MockOptimizer) -> begin
+                MOI.set!(mock, MOI.ObjectiveBound(), 2.0)
+                MOIU.mock_optimize!(mock, MOI.Success, (MOI.FeasiblePoint, [1.5]))
+            end,
+            (mock::MOIU.MockOptimizer) -> begin
+                MOI.set!(mock, MOI.ObjectiveBound(), 4.0)
+                MOIU.mock_optimize!(mock, MOI.Success, (MOI.FeasiblePoint, [1.5]))
+            end
+        )
+        MOIT.solve_objbound_edge_cases(mock, config)
+    end
+
 end
 
 @testset "modifications" begin