Improve documentation of IndexMap #1530
Conversation
|
I guess if I'd tried this locally I would have found the problem. We have a bootstrap issue: IndexMap needs Utilities.DoubleDicts, but Utilities needs IndexMap. this was why it was in MOI.Utilities in the first place. I may just add a |
odow
changed the title
| dest::ModelLike, | ||
| src::ModelLike; | ||
| copy_names::Bool = true, | ||
| warn_attributes::Bool = true, |
There was a problem hiding this comment.
@blegat do we really use this warn_attributes thing? Perhaps we should just remove? We don't really copy optimizer attributes.
There was a problem hiding this comment.
We should remove in MOI v0.10. It was left for when we implement copy of optimizer attributes but since CachingOptimizer don't use copy_to for that, I don't thing we will copy optimizer attributes in copy_to.
| copy_to( | ||
| dest::ModelLike, | ||
| src::ModelLike; | ||
| copy_names::Bool = true, |
There was a problem hiding this comment.
Remind me why we need copy_names? Why can't we just try by default, and skip if they aren't supported?
Closes #1527
Just a look at what this would look like.