Skip to content

Define bridge in MOIB #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2018
Merged

Define bridge in MOIB #325

merged 1 commit into from
Apr 21, 2018

Conversation

blegat
Copy link
Member

@blegat blegat commented Apr 20, 2018

Discussed in #320 (comment)
There is a slight increase in loading time but it does not seem significant. As JuMP might define these bridges anyway, it should affect JuMP's loading time.

Before this PR:

$ julia
julia> @time using MathOptInterface
  0.547734 seconds (460.14 k allocations: 25.334 MiB, 10.26% gc time)
$ julia
julia> @time using MathOptInterface
  0.548062 seconds (460.14 k allocations: 25.335 MiB, 9.92% gc time)

After this PR:

$ julia
julia> @time using MathOptInterface
  0.593794 seconds (513.22 k allocations: 27.837 MiB, 9.64% gc time)
$ julia
julia> @time using MathOptInterface
  0.591734 seconds (513.22 k allocations: 27.837 MiB, 9.62% gc time)

@codecov-io
Copy link

codecov-io commented Apr 20, 2018

Codecov Report

Merging #325 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   96.48%   96.45%   -0.04%     
==========================================
  Files          30       30              
  Lines        4525     4514      -11     
==========================================
- Hits         4366     4354      -12     
- Misses        159      160       +1
Impacted Files Coverage Δ
src/Bridges/bridge.jl 98.61% <0%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b9719b...1e85da7. Read the comment docs.

Copy link
Member

@mlubin mlubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big improvement for usability.

@blegat blegat merged commit b634ecd into master Apr 21, 2018
@blegat blegat deleted the bl/defbridge branch April 21, 2018 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants