Update Model #389
Merged
Update Model #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
reviewed
Jun 14, 2018
|
I think it is a strict improvement. I expect that the cost of doing this change now will be lower than the cost of not having this improvement. |
|
Okay, I'm going to merge this across and have a go at getting the tests to pass. |
mlubin
pushed a commit
that referenced
this pull request
Jun 20, 2018
* Begin refactor from `modifyconstraint(m, c, set)` to `set!(m, ConstraintSet(), c, set)`. This patch currently errors as it needs to be implemented for src/Utilities/model.jl, but I'm not sure where to start. * Update Model (#389) Updates from @blegat * Resolve ambiguity errors relating to canset and set! ConstraintSet. * Fixes to get tests passing * Refactor modfiyconstraint!(m,c,f) to set!(m,ConstraintFunction(),c,f) * Refactor modifyconstraint! to modify! and canmodifycontraint to canmodify. These functions now only apply to AbstractFunctionModification changes. * Fix definition of canmodify. This patch does not pass tests due to problems with canmodify in the bridge code. * Add broken tests * Add unit tests for setting ConstraintSet * Refactor modifyobjective! to modify!(m, ObjectiveFunction, change). * Add more tests for modifications * Begin documentation of problem modificatino * Add more modification tests * Add test for modifying constraint function. There is a broken test and one commented out as MockOptimizer fails getting the constraint function. * Fix bridges tests * Fix set! ConstraintFunction for mock optimizer * Add more tests for default fallbacks * Add more documentation, tests for MultirowChange, and fix associated bug. * Refactor transformconstraint! to transform!. Currently this is not tested as transform! is not implemented in MockOptimizer * Update modification docs with comments from @mlubin * Address method ambiguity * Refactor canset and set! to reduce method ambiguities * Fix typo * Fix cantransform * Address comments by @blegat * Re-enable transform test * Address comments by @mlubin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test still fails for the bridges because of the ambiguity mentioned in #388 (comment)