Skip to content

Turn warnings into errors in CI and fix last remaining warnings #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 15, 2018

Conversation

blegat
Copy link
Member

@blegat blegat commented Jun 14, 2018

Closes #385

@codecov-io
Copy link

codecov-io commented Jun 14, 2018

Codecov Report

Merging #393 into master will increase coverage by 0.02%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #393      +/-   ##
=========================================
+ Coverage   96.47%   96.5%   +0.02%     
=========================================
  Files          39      39              
  Lines        4914    4915       +1     
=========================================
+ Hits         4741    4743       +2     
+ Misses        173     172       -1
Impacted Files Coverage Δ
src/Test/contconic.jl 100% <ø> (ø) ⬆️
src/Bridges/Bridges.jl 100% <ø> (ø) ⬆️
src/Utilities/mockoptimizer.jl 97.46% <ø> (-0.02%) ⬇️
src/constraints.jl 80% <100%> (ø) ⬆️
src/functions.jl 100% <100%> (ø) ⬆️
src/Test/UnitTests/constraints.jl 100% <100%> (ø) ⬆️
src/indextypes.jl 62.5% <100%> (ø) ⬆️
src/Bridges/bridgeoptimizer.jl 98.93% <100%> (ø) ⬆️
src/Bridges/soctopsdbridge.jl 100% <100%> (ø) ⬆️
src/Test/modellike.jl 100% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc56507...0033d56. Read the comment docs.

@mlubin mlubin merged commit 87f6e6e into master Jun 15, 2018
@mlubin mlubin deleted the bl/nowarnings branch June 15, 2018 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants