Improve quadratic support in MOIU #481
Conversation
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
==========================================
+ Coverage 95.32% 95.38% +0.06%
==========================================
Files 46 46
Lines 4640 4681 +41
==========================================
+ Hits 4423 4465 +42
+ Misses 217 216 -1
Continue to review full report at Codecov.
|
src/Utilities/functions.jl
Outdated
| scalar_term = MOI.ScalarAffineTerm(coefficient, t1.scalar_term.variable_index) | ||
| return MOI.VectorAffineTerm(t1.output_index, scalar_term) | ||
| function unsafe_add(t1::MOI.ScalarQuadraticTerm, t2::MOI.ScalarQuadraticTerm) | ||
| return MOI.ScalarAffineTerm(t1.coefficient + t2.coefficient, |
There was a problem hiding this comment.
Is this correct? The docstring says it returns a ScalarQuadraticTerm.
src/functions.jl
Outdated
| coefficient(t::Union{ScalarAffineTerm, ScalarQuadraticTerm | ||
| VectorAffineTerm, VectorQuadraticTerm}) | ||
|
|
||
| Finds the coefficient associated with the term `t`. |
There was a problem hiding this comment.
"associated with" implies lookup in a container. It's clearer to say "stored in".
src/Utilities/constraints.jl
Outdated
| add_scalar_constraint(model::MOI.ModelLike, | ||
| func::MOI.AbstractScalarFunction, | ||
| set::MOI.AbstractScalarSet; | ||
| own_function::Bool=false) |
There was a problem hiding this comment.
When reading this without the documentation it's not clear if own_function means that the caller owns the function or that add_scalar_constraint takes ownership of the function. What about allow_modify_function?
This PR contains changes in MOIU of #478. They shouldn't be blocked by the SOCtoQuad bridge