Define convert #504
Define convert #504
Conversation
|
|
||
| # Define shortcuts for | ||
| # SingleVariable -> ScalarAffineFunction | ||
| function ScalarAffineFunction{T}(f::SingleVariable) where T |
There was a problem hiding this comment.
Is it still Julia convention (post-1.0) to add constructor methods for conversions like this?
There was a problem hiding this comment.
If I understand correctly, since constructors are the low level functions for building objects, convert should redirect to constructors not the opposite. See https://discourse.julialang.org/t/recommended-style-for-conversion-vs-constructors-in-v0-7/11561/5
|
Please fix the CI failure before merging. |
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
==========================================
+ Coverage 95.39% 98.92% +3.53%
==========================================
Files 46 43 -3
Lines 4694 3828 -866
==========================================
- Hits 4478 3787 -691
+ Misses 216 41 -175
Continue to review full report at Codecov.
|
It will be quite hard to implement
MOI.get(::OptimizerType, ::ObjectiveFunction{T})passing the unit test added in #502 without the convert functions added in this PR.The two conversions that were present in MOIU were moved to MOI as they do not add utilites but rather define constructor of MOI types.