Define is_copyable and is_set_by_optimize #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlubin
reviewed
Aug 27, 2018
docs/src/apireference.md
Outdated
|
|
||
| * it is either set when the model is created like [`SolverName`](@ref) and | ||
| [`RawSolver`](@ref), | ||
| * or explicitely when the model is copied like |
docs/src/apireference.md
Outdated
|
|
||
| * it is either set when the model is created like [`SolverName`](@ref) and | ||
| [`RawSolver`](@ref), | ||
| * or explicitely when the model is copied like |
There was a problem hiding this comment.
Why the line break here? Does it actually exceed 80 characters?
docs/src/apireference.md
Outdated
| [`RawSolver`](@ref), | ||
| * or explicitely when the model is copied like | ||
| [`ObjectiveSense`](@ref), | ||
| * or implicitely like [`NumberOfVariables`](@ref) |
docs/src/apireference.md
Outdated
| [`RawSolver`](@ref), | ||
| * or explicitely when the model is copied like | ||
| [`ObjectiveSense`](@ref), | ||
| * or implicitely like [`NumberOfVariables`](@ref) |
There was a problem hiding this comment.
Another example of implicit setting is add_constraint
docs/src/apireference.md
Outdated
| * or it is set to contain the result of the optimization during | ||
| [`optimize!`](@ref) like [`VariablePrimal`](@ref). | ||
|
|
||
| The following functions allows to distinguish between different some of these |
There was a problem hiding this comment.
"some of these different categories"
src/attributes.jl
Outdated
| supports(::ModelLike, ::Union{AbstractVariableAttribute, AbstractConstraintAttribute}, ::Type{<:Index}) = false | ||
| function supports(::ModelLike, attr::Union{AbstractModelAttribute, | ||
| AbstractOptimizerAttribute}) | ||
| @assert is_copyable(attr) |
There was a problem hiding this comment.
Prefer error messages over assert for checking user-facing inputs.
src/attributes.jl
Outdated
| @@ -294,7 +307,9 @@ struct SolverName <: AbstractOptimizerAttribute end | |||
| """ | |||
| ListOfModelAttributesSet() | |||
|
|
|||
| A model attribute for the `Vector{AbstractModelAttribute}` of all model attributes that were set to the model. | |||
| A model attribute for the `Vector{AbstractModelAttribute}` of all model | |||
| attributes `attr` such that `is_copyable(attr)` returns `true` that were set to | |||
There was a problem hiding this comment.
such that 1) is_copyable(attr) returns true and 2) the attribute was set.
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
=========================================
+ Coverage 95.59% 95.6% +<.01%
=========================================
Files 46 46
Lines 4700 4707 +7
=========================================
+ Hits 4493 4500 +7
Misses 207 207
Continue to review full report at Codecov.
|
mlubin
approved these changes
Aug 27, 2018
docs/src/apireference.md
Outdated
| * or it is set to contain the result of the optimization during | ||
| [`optimize!`](@ref) like [`VariablePrimal`](@ref). | ||
|
|
||
| The following functions allows to distinguish between some of these different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #480