Fixed broken Julia LSP support + fixed broken MarkDown LSP support #1101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o have the same in `is_installed_args`. Otherwise, it is erroneously brought to believe that Julia Language Server is not installed.
…ed-language-server` was not found. Now, it is possible to specify multiple locations with `script` were to look for the node script.
… Relative directories such as `.` as was before configured are no longer supported.
…wn-languageserver`
…wn-languageserver`
…35eaf67c34f37e87b52a10f43cfd
|
|
krassowski
reviewed
Jan 8, 2025
| @@ -213,17 +213,18 @@ class LanguageServerManagerAPI(LoggingConfigurable, HasListeners): | |||
| help=_("additional absolute paths to seek node_modules first"), | |||
| ).tag(config=True) | |||
|
|
|||
| def find_node_module(self, *path_frag): | |||
| def find_node_module(self, node_module, alternatives): | |||
There was a problem hiding this comment.
I think this constitutes a breaking change as language specs inheriting from NodeModuleSpec will no longer work. One way to add it in backward compatible way would be to add a new method with new signature and make the old method call the new one.
|
Thank you for the PR, sorry I missed it back in October! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
unified-language-serverwithvscode_markdown_languageserver. See issues raised at https://discourse.jupyter.org/t/how-to-install-and-run-markdown-language-server/24286/3Code changes
Changes are documented in the commits.
User-facing changes
No visual changes in the settings.
Backwards-incompatible changes
No changes to API.
Chores
I am glad to contribute to all chores if the PR will be considered and the bugs eventually fixed upstream. Before investing more time, I prefer to wait for some reactions from the maintainers. Thanks for your understanding.
Changes are anyhow very limited and small in their extent.