Skip to content

Make IStatusBar optional for resourceStatusPlugin #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2023
Merged

Make IStatusBar optional for resourceStatusPlugin #207

merged 1 commit into from
Jul 28, 2023

Conversation

mahendrapaipuri
Copy link
Contributor

IStatusBar does not exist for Nb frontend and we should load the extension only for lab frontend.

@mahendrapaipuri
Make IStatusBar optional for resourceStatusPlugin
bfc4aff 
It does not exist for nb interface and so we should load it optionally
@jtpio jtpio added this to the 1.0.0 milestone Jul 28, 2023
jtpio
jtpio approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 0fadc0b into jupyter-server:main Jul 28, 2023
@mahendrapaipuri mahendrapaipuri deleted the nb7_compatability branch July 28, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mahendrapaipuri @jtpio