Make NBResuse more flexible. #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ghly extensible configuration capapble of using (almost) all psutil metrics.
…e with previous versions. However this seems to now be sufficiently abstract as to be at the cusp of rapid 'expandability' in terms of its features. The next step will be to automatically make as many prometheus Gauge's as needed to measure every specificied metric, i.e. without defining them all manually. setattr will be useful for this I believe.
krinsman
commented
Apr 19, 2020
|
|
||
| MAX_CPU_USAGE = Gauge("max_cpu_usage", "counter for max cpu usage", []) | ||
| self.TOTAL_MEMORY_USAGE = Gauge( |
There was a problem hiding this comment.
I would eventually like to replace these manually specified attributes and attribute names (one for each gauge) with automatically generated ones based on the user's specified configuration, using for loops similar to what was done here in NBViewer.
I think computing the value for the third argument of setattr will be more complicated than just getting an entry from a dictionary based on its key, but it should still be regular enough that it could be encompassed in a function, allowing the calls to setattr to still be legible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First change is to make CPU limit also callable, and thus have almost identical patterns for memory and CPU metrics. Next step is to abstract and generalize those patterns, to allow for potentially arbitrary
psutilmetrics to be tracked. Third step is to begin to allow the metrics which are tracked to be controlled via the configurations/settings file.Using these it should soon be possible to track network i/o with NBResuse, compare the
psutildocumentation.For system-wide metrics, psutil offers the categories of:
For process-specific metrics,
psutiloffers the categories of:By limiting the scope of what NBResuse attempts to support only to metrics which are (1) cross-platform, and which (2) correspond to either a numerical return value or a numerical attribute of a named tuple return value, this might be feasible+maintainable.