Skip to content

Adding kernel specific metrics to nbresuse #40 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 59 additions & 5 deletions nbresuse/prometheus.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
from typing import Optional

from notebook.notebookapp import NotebookApp
from tornado import gen
from notebook.utils import maybe_future
from prometheus_client import Gauge
from psutil import process_iter, AccessDenied, NoSuchProcess

from nbresuse.metrics import PSUtilMetricsLoader

Expand All @@ -18,14 +20,21 @@ def __init__(self, metricsloader: PSUtilMetricsLoader):
self.metricsloader = metricsloader
self.config = metricsloader.config
self.session_manager = metricsloader.nbapp.session_manager
self.kernel_spec_manager = metricsloader.nbapp.kernel_spec_manager

gauge_names = ["total_memory", "max_memory", "total_cpu", "max_cpu"]
gauge_names = ["total_memory", "max_memory", "total_cpu", "max_cpu", "kernel_memory"]
for name in gauge_names:
phrase = name + "_usage"
gauge = Gauge(phrase, "counter for " + phrase.replace("_", " "), [])
if name is "kernel_memory":
label = ['kernel_id']
else:
label = []
gauge = Gauge(phrase, "counter for " + phrase.replace("_", " "), label)
setattr(self, phrase.upper(), gauge)

async def __call__(self, *args, **kwargs):

@gen.coroutine
def __call__(self, *args, **kwargs):
yield self.kernel_metrics()
memory_metric_values = self.metricsloader.memory_metrics()
if memory_metric_values is not None:
self.TOTAL_MEMORY_USAGE.set(memory_metric_values["memory_info_rss"])
Expand Down Expand Up @@ -61,3 +70,48 @@ def apply_cpu_limit(self, cpu_metric_values) -> Optional[float]:
return self.config.cpu_limit
else:
return 100.0 * cpu_metric_values["cpu_count"]

@gen.coroutine
def kernel_metrics(self):
kernels = yield maybe_future(self._list_kernel_memory())
for kernel_id, data in kernels.items():
self.KERNEL_MEMORY_USAGE.labels(kernel_id=kernel_id).set(data['rss'])

@gen.coroutine
def _list_kernel_memory(self):
kernel_memory = dict()

session_manager = self.session_manager
sessions = yield maybe_future(session_manager.list_sessions())
kernel_processes = PrometheusHandler._kernel_processes(self.kernel_spec_manager.get_all_specs())

def find_process(kernel_id):
for proc in kernel_processes:
cmd = proc.cmdline()
if cmd:
last_arg = cmd[-1]
if session_id in last_arg:
return proc
return None

for session in sessions:
kernel = session['kernel']
kernel_id = kernel['id']
kernel_process = find_process(kernel_id)
if kernel_process:
kernel_memory[kernel_id] = kernel_process.memory_info()._asdict()

raise gen.Return(kernel_memory)

@staticmethod
def _kernel_processes(kernel_specs):
for proc in process_iter():
try:
for specs in kernel_specs.values():
for spec in specs.values():
if 'argv' in spec:
key = " ".join(spec.get('argv')[:-1])
if key in " ".join(proc.cmdline()):
yield proc
except (AccessDenied, NoSuchProcess, OSError):
pass