Skip to content

Iterate through set of apps in extension_manager.any_activity method #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Iterate through set of apps in extension_manager.any_activity method #1157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions jupyter_server/extension/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,7 @@ async def stop_all_extensions(self):

def any_activity(self):
"""Check for any activity currently happening across all extension applications."""
for _, app in sorted(dict(self.extension_apps).items()):
if app.current_activity():
return True
for _, apps in sorted(dict(self.extension_apps).items()):
for app in apps:
if app.current_activity():
return True