Skip to content

Fix docs and examples #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/simple/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ module.exports = {
output: {
path: require("path").join(__dirname, "simple_ext1", "static"),
filename: "bundle.js",
hashFunction: 'sha256'
},
mode: "development",
};
11 changes: 6 additions & 5 deletions jupyter_server/services/sessions/sessionmanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,11 @@ async def create_session(
) -> Dict[str, Any]:
"""Creates a session and returns its model

Parameters
----------
name: ModelName(str)
Usually the model name, like the filename associated with current
kernel.


"""
session_id = self.new_session_id()
record = KernelSessionRecord(session_id=session_id)
Expand All @@ -300,13 +300,13 @@ def get_kernel_env(
) -> Dict[str, str]:
"""Return the environment variables that need to be set in the kernel

Parameters
----------
path : str
the url path for the given session.
name: ModelName(str), optional
Here the name is likely to be the name of the associated file
with the current kernel at startup time.


"""
if name is not None:
cwd = self.kernel_manager.cwd_for_path(path)
Expand All @@ -324,6 +324,8 @@ async def start_kernel_for_session(
) -> str:
"""Start a new kernel for a given session.

Parameters
----------
session_id : str
uuid for the session; this method must be given a session_id
path : str
Expand All @@ -335,7 +337,6 @@ async def start_kernel_for_session(
the type of the session
kernel_name : str
the name of the kernel specification to use. The default kernel name will be used if not provided.

"""
# allow contents manager to specify kernels cwd
kernel_path = await ensure_async(self.contents_manager.get_kernel_path(path=path))
Expand Down