Skip to content

Add top-level LICENSE file #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dcsaba89
Copy link
Contributor

@dcsaba89 dcsaba89 commented Feb 2, 2023

Add top-level LICENSE file

Add top-level LICENSE file
@welcome
Copy link

welcome bot commented Feb 2, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 79.14% // Head: 80.44% // Increases project coverage by +1.30% 🎉

Coverage data is based on head (862998e) compared to base (f3fe168).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
+ Coverage   79.14%   80.44%   +1.30%     
==========================================
  Files          68       68              
  Lines        8117     8117              
  Branches     1584     1584              
==========================================
+ Hits         6424     6530     +106     
+ Misses       1280     1173     -107     
- Partials      413      414       +1     
Impacted Files Coverage Δ
jupyter_server/base/handlers.py 78.82% <0.00%> (+0.58%) ⬆️
jupyter_server/utils.py 85.46% <0.00%> (+5.81%) ⬆️
jupyter_server/serverapp.py 80.12% <0.00%> (+7.98%) ⬆️
jupyter_server/services/shutdown.py 100.00% <0.00%> (+23.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073
Copy link
Contributor

Hi @dcsaba89, our top level license file is called COPYING.md and is included in our distributed package.

@dcsaba89
Copy link
Contributor Author

dcsaba89 commented Feb 2, 2023

Hi @blink1073, that file could not be recognized as a license file and causing issues for us, that is why I commited a new license file based on the following guide:
https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository

Please take a look at other repositories, the license file is in the root of the repository and called LICENSE or maybe LICENSE.txt

https://github.com/pandas-dev/pandas/blob/main/LICENSE
https://github.com/numpy/numpy/blob/main/LICENSE.txt
https://github.com/ipython/ipython/blob/main/LICENSE
https://github.com/jupyter/nbclassic/blob/main/LICENSE
https://github.com/jupyter-widgets/ipywidgets/blob/main/LICENSE

And you can see a badge on the top of the pages that shows the license itself and the associated permissions, limitations and conditions as well.

However you cannot see this badge for your top level license file
https://github.com/jupyter-server/jupyter_server/blob/main/COPYING.md

This change would help significantly to update jupyter server more frequently for our python projects.

@blink1073
Copy link
Contributor

I think it is fine to rename the top level file to LICENSE, if you'd like to do that instead. Can you elaborate on what other issue this is causing other than the GitHub UX?

@dcsaba89
Copy link
Contributor Author

dcsaba89 commented Feb 2, 2023

Thanks @blink1073, created a new PR [https://github.com//pull/1196] to rename COPYING.md to LICENSE as you advised, but I am not sure how the original COPYING.md was created

@blink1073
Copy link
Contributor

Closing in favor of #1196

@blink1073 blink1073 closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants