-
Notifications
You must be signed in to change notification settings - Fork 348
Add top-level LICENSE file #1195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add top-level LICENSE file
Thanks for submitting your first pull request! You are awesome! 🤗 |
Codecov ReportBase: 79.14% // Head: 80.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1195 +/- ##
==========================================
+ Coverage 79.14% 80.44% +1.30%
==========================================
Files 68 68
Lines 8117 8117
Branches 1584 1584
==========================================
+ Hits 6424 6530 +106
+ Misses 1280 1173 -107
- Partials 413 414 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi @dcsaba89, our top level license file is called COPYING.md and is included in our distributed package. |
Hi @blink1073, that file could not be recognized as a license file and causing issues for us, that is why I commited a new license file based on the following guide: Please take a look at other repositories, the license file is in the root of the repository and called LICENSE or maybe LICENSE.txt https://github.com/pandas-dev/pandas/blob/main/LICENSE And you can see a badge on the top of the pages that shows the license itself and the associated permissions, limitations and conditions as well. However you cannot see this badge for your top level license file This change would help significantly to update jupyter server more frequently for our python projects. |
I think it is fine to rename the top level file to |
Thanks @blink1073, created a new PR [https://github.com//pull/1196] to rename COPYING.md to LICENSE as you advised, but I am not sure how the original COPYING.md was created |
Closing in favor of #1196 |
Add top-level LICENSE file