Skip to content

Backport PR #1233 on branch 1.x (Added error propagation to gateway_request function) (#1234) #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #1233: Added error propagation to gateway_request function

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.30 🎉

Comparison is base (a777102) 69.23% compared to head (5cc32ec) 71.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1234      +/-   ##
==========================================
+ Coverage   69.23%   71.53%   +2.30%     
==========================================
  Files          62       62              
  Lines        7564     7835     +271     
  Branches     1128     1548     +420     
==========================================
+ Hits         5237     5605     +368     
+ Misses       1935     1838      -97     
  Partials      392      392              
Impacted Files Coverage Δ
jupyter_server/gateway/gateway_client.py 68.57% <0.00%> (+3.00%) ⬆️
jupyter_server/view/handlers.py 100.00% <0.00%> (ø)
jupyter_server/services/api/handlers.py 100.00% <0.00%> (ø)
jupyter_server/terminal/api_handlers.py 100.00% <0.00%> (ø)
jupyter_server/services/config/manager.py 100.00% <0.00%> (ø)
jupyter_server/services/config/handlers.py 100.00% <0.00%> (ø)
jupyter_server/services/security/handlers.py 100.00% <0.00%> (ø)
jupyter_server/services/contents/handlers.py 86.55% <0.00%> (+0.14%) ⬆️
jupyter_server/extension/serverextension.py 71.62% <0.00%> (+0.19%) ⬆️
jupyter_server/services/sessions/sessionmanager.py 88.47% <0.00%> (+0.21%) ⬆️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 changed the title Backport PR #1233 on branch 1.x (Added error propagation to gateway_request function) Backport PR #1233 on branch 1.x (Added error propagation to gateway_request function) (#1234)Co-authored-by: Broden Wanner <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Steven Silvester <[email protected]> Mar 8, 2023
@blink1073 blink1073 merged commit 513df71 into jupyter-server:1.x Mar 8, 2023
@blink1073 blink1073 changed the title Backport PR #1233 on branch 1.x (Added error propagation to gateway_request function) (#1234)Co-authored-by: Broden Wanner <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Steven Silvester <[email protected]> Backport PR #1233 on branch 1.x (Added error propagation to gateway_request function) (#1234) Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants