Skip to content

log extension import time at debug level unless it's actually slow #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2023
Merged

log extension import time at debug level unless it's actually slow #1375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jupyter_server/extension/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ def get_metadata(package_name, logger=None):
# each module took to import. This makes it much easier for users to report
# slow loading modules upstream, as slow loading modules will block server startup
if logger:
logger.info(f"Package {package_name} took {duration:.4f}s to import")
log = logger.info if duration > 0.1 else logger.debug
log(f"Extension package {package_name} took {duration:.4f}s to import")

try:
return module, module._jupyter_server_extension_points()
Expand Down