give authorizer handle on identity provider #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsailer
approved these changes
May 3, 2022
|
LGTM, thanks @blink1073 |
In many cases of custom implementations, these two will have some coupling. So it makes sense for the Authorizer to have access to the identity provider for shared info. e.g. the HubAuth object, when working with JupyterHub.
Zsailer
force-pushed
the
authorizer-identity-handle
branch
from
f229230 to
0ec74a3
Compare
Haha, or @minrk... |
|
🤦 |
|
Thanks, @minrk 🤣 . Reviewing too many PRs in the early morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases of custom implementations, these two will have some coupling. So it makes sense for the Authorizer to have access to the identity provider for shared info.
e.g. the HubAuth object, when working with JupyterHub.