Skip to content

Switch away from deprecated zmqhandlers module in Jupyter Server 2.0 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Switch away from deprecated zmqhandlers module in Jupyter Server 2.0 #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d43f9f
switch away from deprecated module
Zsailer Nov 20, 2022
3abcc3d
ensure rc5
blink1073 Nov 21, 2022
11ef6ab
update mypy dep
blink1073 Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ repos:
- id: mypy
exclude: jupyter_client/tests
args: ["--config-file", "pyproject.toml"]
additional_dependencies: [tornado, pytest, traitlets, jupyter_server, terminado]
additional_dependencies: [tornado, pytest, traitlets, jupyter_server>=2.0.0rc5, terminado]
stages: [manual]

- repo: https://github.com/python-jsonschema/check-jsonschema
Expand Down
2 changes: 1 addition & 1 deletion jupyter_server_terminals/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from jupyter_server._tz import utcnow
from jupyter_server.auth.utils import warn_disabled_authorization
from jupyter_server.base.handlers import JupyterHandler
from jupyter_server.base.zmqhandlers import WebSocketMixin
from jupyter_server.base.websocket import WebSocketMixin
except ModuleNotFoundError:
raise ModuleNotFoundError("Jupyter Server must be installed to use this extension.")

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Homepage = "https://jupyter.org"
[project.optional-dependencies]
test = [
"coverage",
"jupyter_server[test]>=2.0.0rc3",
"jupyter_server[test]>=2.0.0rc5",
"pytest>=7.0",
"pytest_tornasync",
"pytest-cov",
Expand Down