Skip to content

Refactor fixtures #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2022
Merged

Refactor fixtures #26

merged 2 commits into from
Nov 27, 2022

Conversation

blink1073
Copy link
Contributor

Move more logic and fixtures including io_loop into core so they can be shared.
Prefix fixture names where appropriate.
Automatically install echo kernel in base environment.

@blink1073 blink1073 added the enhancement New feature or request label Nov 27, 2022
@blink1073 blink1073 enabled auto-merge (squash) November 27, 2022 22:52
@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Base: 94.82% // Head: 94.39% // Decreases project coverage by -0.43% ⚠️

Coverage data is based on head (e364a1a) compared to base (8b054c0).
Patch coverage: 95.16% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   94.82%   94.39%   -0.44%     
==========================================
  Files          10       10              
  Lines         464      464              
==========================================
- Hits          440      438       -2     
- Misses         24       26       +2     
Impacted Files Coverage Δ
pytest_jupyter/__init__.py 100.00% <ø> (ø)
pytest_jupyter/jupyter_core.py 96.42% <93.18%> (-3.58%) ⬇️
pytest_jupyter/jupyter_client.py 89.65% <100.00%> (-3.45%) ⬇️
pytest_jupyter/jupyter_server.py 92.69% <100.00%> (-0.30%) ⬇️
tests/test_jupyter_client.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit e6b05fe into jupyter-server:main Nov 27, 2022
@blink1073 blink1073 deleted the cleanup branch November 27, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant