-
Notifications
You must be signed in to change notification settings - Fork 3k
add grpcio grpcio-status to support spark connect #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I sorted install entries and fixed package name, it should be |
Pyspark mentions these packages are required for Spark Connect, so it seems to be reasonable to install them. @bjornjorgensen may I ask you to take a look here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update https://github.com/jupyter/docker-stacks/blob/main/docs/using/selecting.md#jupyterpyspark-notebook with newly added packages.
@mathbunnyru docs is updated |
It seams like we need to add versions and googleapis-common-protos
|
@bjornjorgensen grpcio and grpcio-status versions are added. There is no need to dep googleapis-common-protos directly which is a traverse dep of grpcio-status |
Please, update this file, to fix the tests: https://github.com/jupyter/docker-stacks/blob/main/tests/base-notebook/test_packages.py#L68 |
@mathbunnyru thanks for your tips |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xieshuaihu a small tip for the future: try to keep lists sorted, if they are already sorted and you add new items to them.
Sorry for that, I didn't know the lists sorted. And Thanks again for your patience and tips |
@xieshuaihu please, fix the build failure. |
I am solving the deps conflict |
@mathbunnyru I inspected pyspark setup.py, the required grpcio version is >=1.56, so i removed the version |
It sees like this doc is out of date |
Thanks, it makes sense. |
I don't know why the build failure again... |
I inspected this build error, It seems like test-sparklyr in all-spark-notebook was failed. I don't know sparklry, help is expected! |
This most likely has nothing to do with your PR. |
Restart helped, merging this PR. |
@xieshuaihu images have been updated, could you please test, that there is no error now? |
Thanks very much, @mathbunnyru . I will test it today. |
I pulled the latest image, and run the following code, it works. from pyspark.sql import SparkSession
spark = SparkSession.builder.remote("sc://host:port/;user_id=test").getOrCreate()
spark.sql("show databases").show() |
Describe your changes
add grpcio and grpcio_status package in pyspark-notebook.
Before this pr, the pyspark-notebook:spark-3.5.0 will throw exception when connect to spark connect

Checklist (especially for first-time contributors)