Allow for additional, or alternative, options for proxy request #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nokome
pushed a commit
to nokome/nbstencilaproxy
that referenced
this pull request
Nov 19, 2018
Currently executing cells in a Stencila document that run for longer than 20s (the tornado default) will fail with status code 500 and message "Timeout during request". e.g. ```python import time time.sleep(25) ``` This (arbitrarily) increases the timeout to 1hr. It relies on this PR upstream jupyterhub/jupyter-server-proxy#56. It can be tested in `repo2docker` using: ``` ${NB_PYTHON_PREFIX}/bin/pip install --no-cache --process-dependency-links https://github.com/nokome/nbstencilaproxy/archive/master.tar.gz && ``` The `dependency_links` can be dropped in `setup.py`, if the upstream PR gets merged.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows handler classes that extend
LocalProxyHandlerto specify additional, or alternative, arguments totornado.httpclient.HTTPRequestwhen proxying.For example, this was needed so that we could increase the
request_timeoutin https://github.com/minrk/nbstencilaproxy to handle the execution of long running cells.