Added "Folding" Keybindings #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 25, 2020 11:05
New keybindings z-c : close selected cell code z-o : open selected cell code z-m : close all cell code z-r : open all cell code
ianhi
reviewed
Apr 26, 2020
There was a problem hiding this comment.
I tried this out and it works, it's definitely a great addition!
I made suggestions for the documentation language as these commands are really working with cell objects rather than lines of code as in normal vim. But I think it could definitely be merged as is.
Fixed language consistency. Co-Authored-By: Ian Hunt-Isaak <[email protected]>
Fix language consistency Co-Authored-By: Ian Hunt-Isaak <[email protected]>
|
@ianhi , I approved your changes to make the language more clear. |
axelfahy
approved these changes
May 19, 2020
|
@axelfahy thanks for adding! Does adding a new feature warrant a new release? |
|
@ianhhi you're welcome. I am not sure what you mean by warrant, but to make the feature available easily (without cloning and compiling), a new release has to be made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the following keybindings to hide and show code blocks analogous to vim folding.
Z, Chides the code in the selected cellZ, Oshows the code in the selected cellZ, Mhides the code in all cellsZ, Rshows the code in all cellsI also bumped the version and added these shortcuts to
README.md.