Skip to content
This repository was archived by the owner on Jul 9, 2023. It is now read-only.

Dns resolve from code #496

Merged
merged 3 commits into from
Sep 27, 2018
Merged

Dns resolve from code #496

merged 3 commits into from
Sep 27, 2018

Conversation

justcoding121
Copy link
Owner

Doneness:

  • Build is okay - I made sure that this change is building successfully.
  • No Bugs - I made sure that this change is working properly as expected. It doesn't have any bugs that you are aware of.
  • Branching - If this is not a hotfix, I am making this request against master branch

@AppVeyorBot
Copy link

@justcoding121 justcoding121 merged commit 08167b4 into beta Sep 27, 2018
@gustyr
Copy link

gustyr commented Oct 5, 2018

I have an issue with this change when using an external proxy. Latest stable 3.0.684 was working fine.

https://github.com/justcoding121/Titanium-Web-Proxy/blob/bf983616ba51ece4ce7587a568760068e4e5b578/src/Titanium.Web.Proxy/Network/Tcp/TcpConnectionFactory.cs#L290

Dns.GetHostEntry(hostname) throws exception when using a proxy an upstreamproxy like "10.1.13.1:3128"
using GetHostAddresses no exception is thrown.

justcoding121 added a commit that referenced this pull request Oct 5, 2018
@justcoding121
Copy link
Owner Author

Should be fixed in latest beta.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants