Skip to content
This repository was archived by the owner on Jul 9, 2023. It is now read-only.

nuget package consolidation #586

Merged
merged 5 commits into from
Apr 26, 2019
Merged

nuget package consolidation #586

merged 5 commits into from
Apr 26, 2019

Conversation

honfika
Copy link
Collaborator

@honfika honfika commented Apr 26, 2019

Doneness:

  • Build is okay - I made sure that this change is building successfully.
  • No Bugs - I made sure that this change is working properly as expected. It doesn't have any bugs that you are aware of.
  • Branching - If this is not a hotfix, I am making this request against the master branch

@honfika
Copy link
Collaborator Author

honfika commented Apr 26, 2019

There are 2 dependent nuget packages which can't be upgraded:
Microsoft.Win32.Registry and System.Security.Principal.Windows

Because the newer version of that packages requires .net 4.6+

It blocks the TWP users to update those packages in their projects (in case they are using them)

.net 4.5 and 4.5.1 is not supported anymore.
However .net 4.5.2 is still supported until 2023...

Anyway, it seems that microsoft is not supporting .net 4.5.x in their own newer nuget packages, so what do you think about setting the .net requirement to 4.6?

@honfika
Copy link
Collaborator Author

honfika commented Apr 26, 2019

Or 4.6.1, which is .net standard 2.0.

Some popular nuget packages are also requiring .net 4.6.1+, for example: https://www.nuget.org/packages/AutoMapper/

Hmm, there was somebody in the StreamExtended package issues who needs 4.5.2:(

@justcoding121
Copy link
Owner

We can add another separate build for .net 4.6.1 in addition to .net 4.5 packages we have now. So our NuGet package would be available in .Net 4.5 and .net 4.6, while 4.5 will have the minor issue you mentioned above.

justcoding121
justcoding121 previously approved these changes Apr 26, 2019
@honfika
Copy link
Collaborator Author

honfika commented Apr 26, 2019

Just noticed that those 2 packages are referenced only in the netstandard and netcore builds. (It seems that VS nuget update UI does not support conditional references). So net46 is not needed.

@honfika honfika merged commit 29ffc5b into justcoding121:master Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants