Skip to content

Remove usage of reserved word as function attribute #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2016

Conversation

Lisio
Copy link

@Lisio Lisio commented Jul 19, 2016

Usage of "char" as attribute for _lpad function makes it impossible to compress JS with Closure Compiler without implicitly setting --language_in=ECMASCRIPT5
It also affects all libraries that use php-date-formatter, i.e. https://github.com/xdan/datetimepicker

@axi
Copy link

axi commented Sep 20, 2016

@Lisio thanks for this pull requests that helped me to figure out the problem

@kartik-v kartik-v merged commit 9753f0d into kartik-v:master Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants