Skip to content

Patched meridian and ordinal suffix parse bugs. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

dakuzen
Copy link

@dakuzen dakuzen commented Apr 26, 2017

Patched meridian and ordinal suffix parse bugs.

Scope

  • Bug fix
  • New feature
  • Translation

Changes

The parseDate method was updates to correct:

  • Meridian case sensitivity. When evaluating for AM/PM values a lowercase value was ignored. The value being compared is first forced to uppercase before evaluation.
  • Ordinal suffix format handling. When evaluating a date part that includes an ordinal suffix the vDatePart and vFormatParts arrays become offset. The index for these arrays has been separated.

Alternative Solutions

  • The Ordinal suffix bug could alternatively be resolved by simply removing the ordinal flags S from the vFormatParts array before iterating vDateParts.

@kartik-v kartik-v closed this in d842e1c Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants