Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

upgrade logicalcluster to fix missing WithCluster #15

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

robinbobbitt
Copy link
Contributor

Currently, without this fix:

% make docker-build docker-push IMG=xxx
/Users/rbobbitt/work/projects/controller-runtime-example/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
# github.com/kcp-dev/controller-runtime-example/controllers
controllers/configmap_controller.go:56:23: undefined: logicalcluster.WithCluster
controllers/widget_controller.go:59:23: undefined: logicalcluster.WithCluster
# github.com/kcp-dev/controller-runtime-example/controllers
vet: controllers/configmap_controller.go:56:23: WithCluster not declared by package logicalcluster
make: *** [vet] Error 2

Signed-off-by: Robin Y Bobbitt [email protected]

@ncdc ncdc merged commit 813d765 into kcp-dev:main Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants