Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

Add KCP APIs to scheme, enforce kind image version #34

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Add KCP APIs to scheme, enforce kind image version #34

merged 1 commit into from
Dec 6, 2022

Conversation

vincepri
Copy link
Contributor

@vincepri vincepri commented Dec 6, 2022

While testing out the controller-runtime-example Makefile, specifically running make test-e2e I noticed that the build was failing locally and the controller pod was crashing.

After a bit of debugging, it seems that the scheme was missing KCP's APIExport Kind, which caused the error looking up virtual workspace URL error, and then the panic for the controller.

In addition, this PR enforces a known working version of Kubernetes when testing locally, and it fixes an issue on Mac where the ~ sign (i.e. HOME) wasn't working properly.

Signed-off-by: Vince Prignano [email protected]

While testing out the `controller-runtime-example` Makefile,
specifically running `make test-e2e` I noticed that the build was
failing locally and the controller pod was crashing.

After a bit of debugging, it seems that the scheme was missing KCP's
APIExport Kind, which caused the `error looking up virtual workspace
URL` error, and then the panic for the controller.

In addition, this PR enforces a known working version of Kubernetes when
testing locally, and it fixes an issue on Mac where the ~ sign (i.e. HOME) wasn't
working properly.

Signed-off-by: Vince Prignano <[email protected]>
@openshift-ci openshift-ci bot requested review from davidfestal and sttts December 6, 2022 00:45
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2022

@vincepri: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e c54d624 link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vincepri
Copy link
Contributor Author

vincepri commented Dec 6, 2022

🤔

ERROR: failed to create cluster: failed to get docker info: command "docker info --format '{{json .}}'" failed with error: exec: "docker": executable file not found in $PATH

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, stevekuznetsov, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@stevekuznetsov stevekuznetsov merged commit f227021 into kcp-dev:main Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants