This repository was archived by the owner on Apr 24, 2024. It is now read-only.
Add KCP APIs to scheme, enforce kind image version #34
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing out the
controller-runtime-example
Makefile, specifically runningmake test-e2e
I noticed that the build was failing locally and the controller pod was crashing.After a bit of debugging, it seems that the scheme was missing KCP's APIExport Kind, which caused the
error looking up virtual workspace URL
error, and then the panic for the controller.In addition, this PR enforces a known working version of Kubernetes when testing locally, and it fixes an issue on Mac where the ~ sign (i.e. HOME) wasn't working properly.
Signed-off-by: Vince Prignano [email protected]