This repository was archived by the owner on Apr 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
support non-kcp environment #8
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| # Adds namespace to all resources. | ||
| namespace: controller-runtime-example-system | ||
|
|
||
| # Value of this field is prepended to the | ||
| # names of all resources, e.g. a deployment named | ||
| # "wordpress" becomes "alices-wordpress". | ||
| # Note that it should also match with the prefix (text before '-') of the namespace | ||
| # field above. | ||
| namePrefix: controller-runtime-example- | ||
|
|
||
| # Labels to add to all resources and selectors. | ||
| #commonLabels: | ||
| # someName: someValue | ||
|
|
||
| bases: | ||
| - ../crd | ||
| - ../rbac | ||
| - ../manager | ||
| # [WEBHOOK] To enable webhook, uncomment all the sections with [WEBHOOK] prefix including the one in | ||
| # crd/kustomization.yaml | ||
| #- ../webhook | ||
| # [CERTMANAGER] To enable cert-manager, uncomment all sections with 'CERTMANAGER'. 'WEBHOOK' components are required. | ||
| #- ../certmanager | ||
| # [PROMETHEUS] To enable prometheus monitor, uncomment all sections with 'PROMETHEUS'. | ||
| #- ../prometheus | ||
|
|
||
| patchesStrategicMerge: | ||
| # Protect the /metrics endpoint by putting it behind auth. | ||
| # If you want your controller-manager to expose the /metrics | ||
| # endpoint w/o any authn/z, please comment the following line. | ||
| - manager_auth_proxy_patch.yaml | ||
|
|
||
| # Mount the controller config file for loading manager configurations | ||
| # through a ComponentConfig type | ||
| #- manager_config_patch.yaml | ||
|
|
||
| # [WEBHOOK] To enable webhook, uncomment all the sections with [WEBHOOK] prefix including the one in | ||
| # crd/kustomization.yaml | ||
| #- manager_webhook_patch.yaml | ||
|
|
||
| # [CERTMANAGER] To enable cert-manager, uncomment all sections with 'CERTMANAGER'. | ||
| # Uncomment 'CERTMANAGER' sections in crd/kustomization.yaml to enable the CA injection in the admission webhooks. | ||
| # 'CERTMANAGER' needs to be enabled to use ca injection | ||
| #- webhookcainjection_patch.yaml | ||
|
|
||
| # the following config is for teaching kustomize how to do var substitution | ||
| vars: | ||
| # [CERTMANAGER] To enable cert-manager, uncomment all sections with 'CERTMANAGER' prefix. | ||
| #- name: CERTIFICATE_NAMESPACE # namespace of the certificate CR | ||
| # objref: | ||
| # kind: Certificate | ||
| # group: cert-manager.io | ||
| # version: v1 | ||
| # name: serving-cert # this name should match the one in certificate.yaml | ||
| # fieldref: | ||
| # fieldpath: metadata.namespace | ||
| #- name: CERTIFICATE_NAME | ||
| # objref: | ||
| # kind: Certificate | ||
| # group: cert-manager.io | ||
| # version: v1 | ||
| # name: serving-cert # this name should match the one in certificate.yaml | ||
| #- name: SERVICE_NAMESPACE # namespace of the service | ||
| # objref: | ||
| # kind: Service | ||
| # version: v1 | ||
| # name: webhook-service | ||
| # fieldref: | ||
| # fieldpath: metadata.namespace | ||
| #- name: SERVICE_NAME | ||
| # objref: | ||
| # kind: Service | ||
| # version: v1 | ||
| # name: webhook-service |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # This patch inject a sidecar container which is a HTTP proxy for the | ||
| # controller manager, it performs RBAC authorization against the Kubernetes API using SubjectAccessReviews. | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: controller-manager | ||
| namespace: system | ||
| spec: | ||
| template: | ||
| spec: | ||
| containers: | ||
| - name: kube-rbac-proxy | ||
| image: gcr.io/kubebuilder/kube-rbac-proxy:v0.11.0 | ||
| args: | ||
| - "--secure-listen-address=0.0.0.0:8443" | ||
| - "--upstream=http://127.0.0.1:8080/" | ||
| - "--logtostderr=true" | ||
| - "--v=0" | ||
| ports: | ||
| - containerPort: 8443 | ||
| protocol: TCP | ||
| name: https | ||
| resources: | ||
| limits: | ||
| cpu: 500m | ||
| memory: 128Mi | ||
| requests: | ||
| cpu: 5m | ||
| memory: 64Mi | ||
| - name: manager | ||
| args: | ||
| - "--health-probe-bind-address=:8081" | ||
| - "--metrics-bind-address=127.0.0.1:8080" | ||
| - "--leader-elect" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: controller-manager | ||
| namespace: system | ||
| spec: | ||
| template: | ||
| spec: | ||
| containers: | ||
| - name: manager | ||
| args: | ||
| - "--config=controller_manager_config.yaml" | ||
| volumeMounts: | ||
| - name: manager-config | ||
| mountPath: /controller_manager_config.yaml | ||
| subPath: controller_manager_config.yaml | ||
| volumes: | ||
| - name: manager-config | ||
| configMap: | ||
| name: manager-config |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| creationTimestamp: null | ||
| name: kcp-manager-role | ||
| rules: | ||
| - apiGroups: | ||
| - apis.kcp.dev | ||
| resources: | ||
| - apiexports | ||
| verbs: | ||
| - get | ||
| - list | ||
| - watch | ||
| - apiGroups: | ||
| - apis.kcp.dev | ||
| resources: | ||
| - apiexports/content | ||
| verbs: | ||
| - '*' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRoleBinding | ||
| metadata: | ||
| name: kcp-manager-rolebinding | ||
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: ClusterRole | ||
| name: kcp-manager-role | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: controller-manager | ||
| namespace: system |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| resources: | ||
| - today.apiresourceschemas.yaml | ||
| - apiexport.yaml | ||
| - clusterrole.yaml | ||
| - clusterrolebinding.yaml | ||
|
|
||
| configurations: | ||
| - kustomizeconfig.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move this back out (just inside the else block) and change it back to the
List: got...log message. There can be multiple configmaps in a cluster across all namespaces, and this is supposed to show all of them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but imagine what it looks like when it's "connected" to a normal OpenShift cluster - there are approx. 550 ConfigMaps in the cluster and all of them are printed every time when the leader election updates its own configmap. This makes the whole log unreadable.
That's why I change it so it prints the count of all CMs found either in the cluster or in the workspace, plus: