Replace setup with new Swift-only library #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates the need for handling the internal library, but is potentially still valuable to share this build file, and always force these targets to be built in the opt configuration to avoid performance issues when they're built in dbg
keith
force-pushed
the
ks/replace-setup-with-new-swift-only-library
branch
from
d6143bb to
fd44018
Compare
|
merged into non main branch that will eventually make it back to main |
|
The opt wrapper may no longer be necessary with swiftlang/swift-syntax#1030 |
|
nice, will be interesting to see! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the need for handling the internal library, but is
potentially still valuable to share this build file, and always force
these targets to be built in the opt configuration to avoid performance
issues when they're built in dbg