net: usb: asix: ax88772_bind: use devm_kzalloc() instead of kzalloc()

olerem · davem330 · commit 218d154f540a · 2021-06-07T13:23:02.000-07:00
Make resource management easier, use devm_kzalloc().

Signed-off-by: Oleksij Rempel &lt;o.rempel@pengutronix.de&gt;
Reviewed-by: Andrew Lunn &lt;andrew@lunn.ch&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
@@ -746,11 +746,11 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf)
 		dev->rx_urb_size = 2048;
 	}
 
-	dev->driver_priv = kzalloc(sizeof(struct asix_common_private), GFP_KERNEL);
-	if (!dev->driver_priv)
+	priv = devm_kzalloc(&dev->udev->dev, sizeof(*priv), GFP_KERNEL);
+	if (!priv)
 		return -ENOMEM;
 
-	priv = dev->driver_priv;
+	dev->driver_priv = priv;
 
 	priv->presvd_phy_bmcr = 0;
 	priv->presvd_phy_advertise = 0;
@@ -768,7 +768,6 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf)
 static void ax88772_unbind(struct usbnet *dev, struct usb_interface *intf)
 {
 	asix_rx_fixup_common_free(dev->driver_priv);
-	kfree(dev->driver_priv);
 }
 
 static const struct ethtool_ops ax88178_ethtool_ops = {

Original file line number	Diff line number	Diff line change
`@@ -746,11 +746,11 @@ static int ax88772_bind(struct usbnet dev, struct usb_interface intf)`
`746`	`746`	`dev->rx_urb_size = 2048;`
`747`	`747`	`}`
`748`	`748`
`749`		`- dev->driver_priv = kzalloc(sizeof(struct asix_common_private), GFP_KERNEL);`
`750`		`- if (!dev->driver_priv)`
	`749`	`+ priv = devm_kzalloc(&dev->udev->dev, sizeof(*priv), GFP_KERNEL);`
	`750`	`+ if (!priv)`
`751`	`751`	`return -ENOMEM;`
`752`	`752`
`753`		`- priv = dev->driver_priv;`
	`753`	`+ dev->driver_priv = priv;`
`754`	`754`
`755`	`755`	`priv->presvd_phy_bmcr = 0;`
`756`	`756`	`priv->presvd_phy_advertise = 0;`
`@@ -768,7 +768,6 @@ static int ax88772_bind(struct usbnet dev, struct usb_interface intf)`
`768`	`768`	`static void ax88772_unbind(struct usbnet dev, struct usb_interface intf)`
`769`	`769`	`{`
`770`	`770`	`asix_rx_fixup_common_free(dev->driver_priv);`
`771`		`- kfree(dev->driver_priv);`
`772`	`771`	`}`
`773`	`772`
`774`	`773`	`static const struct ethtool_ops ax88178_ethtool_ops = {`