Skip to content

Commit c797cb9

Browse files
Paul DaveyPaolo Abeni
authored andcommitted
net: phy: marvell: Add mdix status reporting
Report MDI-X resolved state after link up. Tested on Linkstreet 88E6193X internal PHYs. Signed-off-by: Paul Davey <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Paolo Abeni <[email protected]>
1 parent d10f1a4 commit c797cb9

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

drivers/net/phy/marvell.c

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,7 @@
176176
#define MII_M1011_PHY_STATUS_FULLDUPLEX 0x2000
177177
#define MII_M1011_PHY_STATUS_RESOLVED 0x0800
178178
#define MII_M1011_PHY_STATUS_LINK 0x0400
179+
#define MII_M1011_PHY_STATUS_MDIX BIT(6)
179180

180181
#define MII_88E3016_PHY_SPEC_CTRL 0x10
181182
#define MII_88E3016_DISABLE_SCRAMBLER 0x0200
@@ -1722,6 +1723,19 @@ static int marvell_read_status_page(struct phy_device *phydev, int page)
17221723
phydev->duplex = DUPLEX_UNKNOWN;
17231724
phydev->port = fiber ? PORT_FIBRE : PORT_TP;
17241725

1726+
if (fiber) {
1727+
phydev->mdix = ETH_TP_MDI_INVALID;
1728+
} else {
1729+
/* The MDI-X state is set regardless of Autoneg being enabled
1730+
* and reflects forced MDI-X state as well as auto resolution
1731+
*/
1732+
if (status & MII_M1011_PHY_STATUS_RESOLVED)
1733+
phydev->mdix = status & MII_M1011_PHY_STATUS_MDIX ?
1734+
ETH_TP_MDI_X : ETH_TP_MDI;
1735+
else
1736+
phydev->mdix = ETH_TP_MDI_INVALID;
1737+
}
1738+
17251739
if (phydev->autoneg == AUTONEG_ENABLE)
17261740
err = marvell_read_status_page_an(phydev, fiber, status);
17271741
else

0 commit comments

Comments
 (0)