Skip to content

Commit 8748fa0

Browse files
committed
Remove jest
The last diff to achieve testing parity, rescript-lang#361, has been merged. Overall improvements: - We've gone from 7-9s test time to 1.7-1.9s. This is fast enough that we can now plan to run test as part of the build step. Though right now the build is a few seconds which is too slow for tests to squeeze in. Shame. - Roundtrip tests went from 50-60s to 25-30s. - Snapshotting is no longer a dedicated api to learn. Just check the git diff. As I said in rescript-lang#343: > The question to ask is "what am I trying to do with snapshot tests?" and the answer for this repo is "I wanna check whether some files changed". After which you realize it's git's job. - Way cleaner snapshot outputs because no JS and JSON serialization in the way. - Instead of all these red files, it's a single shell test script of a 100 lines.
1 parent 42cb6b8 commit 8748fa0

File tree

135 files changed

+16
-23296
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

135 files changed

+16
-23296
lines changed

syntax/README.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,7 @@ Run the extended tests:
5555
make roundtrip-test
5656
```
5757

58-
Update jest snapshots:
59-
```sh
60-
./node_modules/.bin/jest -u
61-
```
58+
Those will tell you whether you've got a test output difference. If it's intentional, check them in.
6259

6360
Debug a file:
6461
```sh

syntax/jest.config.js

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)