[ci skip] tweak docs and add ocaml syntax coloring support #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbarabash
pushed a commit
to kevinbarabash/rescript-compiler
that referenced
this pull request
Dec 24, 2021
The last diff to achieve testing parity, rescript-lang#361, has been merged. Overall improvements: - We've gone from 7-9s test time to 1.7-1.9s. This is fast enough that we can now plan to run test as part of the build step. Though right now the build is a few seconds which is too slow for tests to squeeze in. Shame. - Roundtrip tests went from 50-60s to 25-30s. - Snapshotting is no longer a dedicated api to learn. Just check the git diff. As I said in rescript-lang#343: > The question to ask is "what am I trying to do with snapshot tests?" and the answer for this repo is "I wanna check whether some files changed". After which you realize it's git's job. - Way cleaner snapshot outputs because no JS and JSON serialization in the way. - Instead of all these red files, it's a single shell test script of a 100 lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.