Skip to content

Fix return types #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Fix return types #24

merged 3 commits into from
Sep 7, 2022

Conversation

madrussa
Copy link
Contributor

@madrussa madrussa commented Sep 5, 2022

  • Fixes return types to be fully qualified to enable code analysers to check return types properly.
    Example running phpstan level 9:
    20     Access to offset 0 on an unknown class Kitar\Dynamodb\Model\Illuminate\Database\Eloquent\Collection.                                                                                        
           💡 Learn more at https://phpstan.org/user-guide/discovering-symbols      
    
  • Implement PSR coding standards for new objects.
  • Fix typo on comment

@kitar
Copy link
Owner

kitar commented Sep 7, 2022

Thank you for the fix! Looks nice :)

@kitar kitar merged commit e6c9063 into kitar:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants