Error with the Dynamo Pagination #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! |
|
Amazing |
|
Great, I also need this fix. Hope it can be merged soon. |
|
@raphaelcangucu It seems like this is something we should have implemented from the beginning. I'd also like to consider removing metadata at the model level in the next major version. We'll release it right after adding some tests and docs! |
|
Thanks! When can we expect the release? |
|
Assuming testing proceeds without any issues, I believe we can release it in a day or two! |
|
Awesome, look forward to it! |
|
Thanks @kitar , let me know if you need some help coding. |
kitar
added a commit
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix last evaluated key when the collection is empty and we can still have results at the dynamo.
When the result don't contain any itens, but we still have a lastEvaluatedKey at the Dynamo response, this means that we still has to confirm if we have or not values at the dynamo.
The function processMultipleItems at the processor was adding the meta at the collection items.
To solve this it was extended the Laravel Collection and created a new attribute to add the meta to the collection, so we can access at the lastEvaluatedKey from the collection instead of the item that don't exist.