Skip to content

Re-added --sdk argument for sdl2 bootstrap, but with a warning #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Re-added --sdk argument for sdl2 bootstrap, but with a warning #1133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pythonforandroid/bootstraps/sdl2/build/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,9 +483,8 @@ def parse_args(args=None):
'(eg: com.android.support:appcompat-v7:19.0.1)'))
## The --sdk option has been removed, it is ignored in favour of
## --android-api handled by toolchain.py
# ap.add_argument('--sdk', dest='sdk_version', default=-1,
# type=int, help=('Android SDK version to use. Default to '
# 'the value of minsdk'))
ap.add_argument('--sdk', dest='sdk_version', default=-1,
type=int, help=('Deprecated argument, does nothing'))
ap.add_argument('--minsdk', dest='min_sdk_version',
default=default_android_api, type=int,
help=('Minimum Android SDK version to use. Default to '
Expand Down Expand Up @@ -522,6 +521,10 @@ def parse_args(args=None):
# if args.sdk_version == -1:
# args.sdk_version = args.min_sdk_version

if args.sdk_version != -1:
print('WARNING: Received a --sdk argument, but this argument is '
'deprecated and does nothing.')

if args.permissions is None:
args.permissions = []
elif args.permissions:
Expand Down