Add lxml recipe and other recipes from ZachGoldberg fork #1166
Conversation
…nto kivy-master
|
Looks good, I'll try to test it. Have you tested it yourself? |
|
|
||
| def get_recipe_env(self, arch): | ||
| env = super(LevenshteinRecipe, self).get_recipe_env(arch) | ||
| libxslt_recipe = Recipe.get_recipe('libxslt', self.ctx) |
There was a problem hiding this comment.
My testing application compiles until these lines get referenced, which I believe may be because the class Recipe is called instead of the instance. But something seems to have accidentally filled my VM up to the brim so I need to clean it out before I can continue testing, so I haven't been able to test the change into an instance.
|
Hello @Scefing and @inclement , any update on this PR? I need lxml in new tool chain, and would be happy to see this PR move forward. I've tried it it's not working at the moment, there are at least the Thanks in advance |
|
@goffi-contrib No update, it isn't something I can prioritise compared to other important changes that are waiting, but testing is welcome in general. About the python 2 part, that may just be a matter of adding python3crystax as a build option, i.e. I haven't thought about the CC options, have you tried the current ones? |
This patch fixes the issues from PR kivy#1166 and has been tested working
This patch fixes the recipes from PR kivy#1166.
|
Hello @Scefing and @inclement I've made a PR with fixes to this one at #1428, this has been tested working. I was not sure how to add the modification, but if you want to stay on this PR, the fixing patch can be found at 4fd0a6d . Thanks a lot for your work! |
This is a squash of many commits comming from kivy#1166 work by Zachary Goldberg (https://github.com/ZachGoldberg) and Elena Pereira (https://github.com/Scefing)
This patch fixes the recipes from PR kivy#1166.
This patch fixes the recipes from PR kivy#1166.
This patch fixes the recipes from PR kivy#1166. levenshtein recipe has been removed has it's not used anywhere and its causing compilation troubles.
This is a squash of many commits comming from kivy#1166 work by Zachary Goldberg (https://github.com/ZachGoldberg) and Elena Pereira (https://github.com/Scefing)
This patch fixes the recipes from PR kivy#1166. levenshtein recipe has been removed has it's not used anywhere and its causing compilation troubles.
|
Hi @AndreMiras I think this PR can be closed now. |
|
Yep true, fixed in #1428 |
This is a merge-compatible fork of https://github.com/ZachGoldberg/python-for-android meant to implement an
lxmlrecipes and other recipes.Please look it over and point out any changes that need to be made so it can be merged. I'd like to use
lxml!