Add support for minimum Android API. #1197
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the compilation to use a different version for compiling while targetting a higher API version. Typically, you may need to use API 23 for Java, but want to run on API 19. If you compile with API 23, when running on older device (let's say 4.4.2), you'll end up with a symbol not found "srand", "signal", etc. It is important to set the Android API minimum version when compiling in order to avoid theses symbol issues. CF: https://stackoverflow.com/a/41079462/69877
|
I also had to change this line to successfully compile python2 still, getting 'srand' missing error from 'libSDL2.so' |
|
@QuadTriangle I just did a quick test and it worked okay, do you know what needs to happen to duplicate your problem? |
akinwale
added a commit
to lbryio/lbry-android
that referenced
this pull request
Apr 11, 2018
… API support. Minimum Android API set to 21.
akinwale
added a commit
to lbryio/lbry-android
that referenced
this pull request
Apr 11, 2018
Integrate fixes from kivy/python-for-android#1197
|
Hi @tito and @inclement was this covered during the recent refactoring in #1412 ? If so feel free to close, otherwise maybe we want to rebase and fix the conflicts. |
|
Yep, the python3 changes implement the same thing (plus some fixes beyond this). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the compilation to use a different version for compiling while targetting a higher API version.
Typically, you may need to use API 23 for Java, but want to run on devices with API 19. If you compile with API 23, when running on older device (let's say 4.4.2), you'll end up with a symbol not found "srand", "signal", etc.
It is important to set the Android API minimum version when compiling in order to avoid theses symbol issues.
CF: https://stackoverflow.com/a/41079462/69877