Introduces linting (tox/flake8) #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes sure lint checks are ran before `docker build` so we fail fast. Currently `flake8` errors are ignored except for `E101` and `W191`. This will demonstrate the fail fast case. Next commit will fix these two errors in the code base.
|
Build is failing as expected. Second commit fixes linter errors and (hopefully) the build. |
AndreMiras
force-pushed
the
feature/tox_flake8_testing
branch
from
8a6924e to
4e13ba7
Compare
- E101 indentation contains mixed spaces and tabs - W191 indentation contains tabs
AndreMiras
force-pushed
the
feature/tox_flake8_testing
branch
from
4e13ba7 to
1a650de
Compare
|
Second commit turns the build back green as expected :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure lint checks are ran before
docker buildso we fail fast.Currently
flake8errors are ignored except forE101andW191.This will demonstrate the fail fast case.
Next commit will fix these two errors in the code base.