Skip to content

fixed #1184 - now cython gets -L of NDK's libraries #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

maho
Copy link
Contributor

@maho maho commented Jul 13, 2018

I noticed that cython fails with error mentioned in #1184 , but workaround is to build kivy first, which copy libpython3.5m.so to .buildozer, and then add cython to requirements.

Solution is, to add NDK path to -L path for compiler/linker. So I did it.

@AndreMiras
Copy link
Member

Thanks for the pull request, I've left a comment regarding the Python version that should not be hardcoded so it also works with e.g. 3.6.
Also make sure to run tox so the linter is happy. See Travis errors here https://travis-ci.org/kivy/python-for-android/jobs/403478690

pep8 create: /home/travis/build/kivy/python-for-android/.tox/pep8
pep8 installdeps: flake8
pep8 runtests: commands[0] | flake8 pythonforandroid/
pythonforandroid/recipes/cymunk/__init__.py:12:4: W291 trailing whitespace
pythonforandroid/recipes/cymunk/__init__.py:13:1: E101 indentation contains mixed spaces and tabs
pythonforandroid/recipes/cymunk/__init__.py:13:1: W191 indentation contains tabs
pythonforandroid/recipes/cymunk/__init__.py:15:1: W191 indentation contains tabs
pythonforandroid/recipes/cymunk/__init__.py:15:2: E101 indentation contains mixed spaces and tabs
pythonforandroid/recipes/cymunk/__init__.py:16:1: E101 indentation contains mixed spaces and tabs
pythonforandroid/recipes/cymunk/__init__.py:21:1: E101 indentation contains mixed spaces and tabs
pythonforandroid/recipes/cymunk/__init__.py:21:1: W191 indentation contains tabs
pythonforandroid/recipes/cymunk/__init__.py:22:1: W191 indentation contains tabs
pythonforandroid/recipes/cymunk/__init__.py:22:2: E101 indentation contains mixed spaces and tabs
pythonforandroid/recipes/cymunk/__init__.py:24:1: E101 indentation contains mixed spaces and tabs
ERROR: InvocationError: '/home/travis/build/kivy/python-for-android/.tox/pep8/bin/flake8 pythonforandroid/'
___________________________________ summary ____________________________________
ERROR:   pep8: commands failed
The command "tox" failed and exited with 1 during .
Your build has been stopped.

@AndreMiras
Copy link
Member

Also now I'm thinking, perhaps you should give a try to #793 because with it your change my not be needed. Could you try and let us know?

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. We recently merged #793 which should also fix it for you. Could you buildozer android update from p4a master (p4a.branch = master) and let us know if it fixes the issue?


api_ver = self.ctx.android_api

flags = " -L{ctx.ndk_dir}/sources/python/3.5/libs/{arch}/"\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rely on the Python version rather than hardcoding 3.5? Because it could also be 3.6 for instance.

@maho
Copy link
Contributor Author

maho commented Aug 10, 2018

current master works without this PR, so is no longer needed

@maho maho closed this Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants