Skip to content

[cryptography] Updated to last available version (2.3.1) #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2018

Conversation

goffi-contrib
Copy link
Contributor

This recipe update cryptography to last version.
Note that "pyasn1" is not anymore a dependency and has been replaced by
"asn1crypto".

url = 'https://github.com/pyca/cryptography/archive/{version}.tar.gz'
depends = [('python2', 'python3crystax'), 'openssl', 'idna', 'pyasn1', 'six', 'setuptools', 'enum34', 'ipaddress', 'cffi']
version = '2.3.1'
url = 'https://files.pythonhosted.org/packages/22/21/233e38f74188db94e8451ef6385754a98f3cad9b59bedf3a8e8b14988be4/cryptography-2.3.1.tar.gz'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the url string and don't hardcode the version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreMiras previous URL is not restored

@AndreMiras
Copy link
Member

AndreMiras commented Nov 4, 2018

Thanks for the pull request. CI is currently complaining with the following:

�[1m�[31m[ERROR]�[39m�[0m:   virtualenv is needed to install pure-Python modules, but
�[1m�[31m[ERROR]�[39m�[0m:   virtualenv does not support nesting, and you are running
�[1m�[31m[ERROR]�[39m�[0m:   python-for-android in one. Please run p4a outside of a
�[1m�[31m[ERROR]�[39m�[0m:   virtualenv instead.

But that should be fixed pretty soon with #1437
Hopefully we can merge it this week, and I'll pick yours after that.

@AndreMiras AndreMiras self-assigned this Nov 4, 2018
@AndreMiras
Copy link
Member

@goffi-contrib #1437 just got merged. Do you mind rebasing to see if Travis is now happy about it?

@goffi-contrib
Copy link
Contributor Author

@AndreMiras done :)

@AndreMiras
Copy link
Member

Damn it, they all rely on libffi which requires autoconf.
So it looks like that one can be added to just like in #1441 (comment)
I'm sorry this is embarrassing 😕
The CI still needs a lot of improvements, but it will come.
It could be easy to just add autoconf install to the Dockerfile, but I'm thinking of a more powerful solution.

This recipe update cryptography to last version.
Note that "pyasn1" is not anymore a dependency and has been replaced by
"asn1crypto".
@AndreMiras
Copy link
Member

We actually decided adding the system dependencies to the container https://github.com/kivy/python-for-android/pull/1457/files#diff-3254677a7917c6c01f55212f86c57fbfR51
So I'm going to give your PR a try manually now and if it seems OK, I'll see if I can fix the conflict and merge without disturbing you one more time 😄

@@ -38,6 +38,7 @@ class TargetPython(Enum):
'm2crypto',
'netifaces',
'Pillow',
'cryptography',
Copy link
Member

@AndreMiras AndreMiras Nov 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the initial comment about the system dependency missing because this was covered in #1457
However Travis is still struggling with cffi which is a dependency of cryptography so I prefer to keep it here for now

@AndreMiras AndreMiras merged commit 3c3d5c4 into kivy:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants