-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[cryptography] Updated to last available version (2.3.1) #1443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
url = 'https://github.com/pyca/cryptography/archive/{version}.tar.gz' | ||
depends = [('python2', 'python3crystax'), 'openssl', 'idna', 'pyasn1', 'six', 'setuptools', 'enum34', 'ipaddress', 'cffi'] | ||
version = '2.3.1' | ||
url = 'https://files.pythonhosted.org/packages/22/21/233e38f74188db94e8451ef6385754a98f3cad9b59bedf3a8e8b14988be4/cryptography-2.3.1.tar.gz' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't change the url
string and don't hardcode the version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndreMiras previous URL is not restored
18fb36a
to
e268ca6
Compare
Thanks for the pull request. CI is currently complaining with the following:
But that should be fixed pretty soon with #1437 |
@goffi-contrib #1437 just got merged. Do you mind rebasing to see if Travis is now happy about it? |
e268ca6
to
02b216d
Compare
@AndreMiras done :) |
Damn it, they all rely on |
This recipe update cryptography to last version. Note that "pyasn1" is not anymore a dependency and has been replaced by "asn1crypto".
02b216d
to
73258b0
Compare
We actually decided adding the system dependencies to the container https://github.com/kivy/python-for-android/pull/1457/files#diff-3254677a7917c6c01f55212f86c57fbfR51 |
@@ -38,6 +38,7 @@ class TargetPython(Enum): | |||
'm2crypto', | |||
'netifaces', | |||
'Pillow', | |||
'cryptography', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the initial comment about the system dependency missing because this was covered in #1457
However Travis is still struggling with cffi
which is a dependency of cryptography
so I prefer to keep it here for now
This recipe update cryptography to last version.
Note that "pyasn1" is not anymore a dependency and has been replaced by
"asn1crypto".