Allow dist overwrite by default #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inclement
force-pushed
the
allow_dist_overwrite
branch
from
06751a4 to
30ac677
Compare
|
@tito This should fix your dist replacement issue |
|
looking good to me, if you could just fix the linter 😬 Use |
AndreMiras
reviewed
Nov 18, 2018
inclement
force-pushed
the
allow_dist_overwrite
branch
from
30ac677 to
1f2291e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My python3 change fixed a bug where dists could be overwritten if a previous dist with the same name but different recipes was present. This wasn't the original intention of the code. However, it looks like the old buggy behaviour was more desirable in practice, so this PR allows dist overwriting by default but adds an option to configure it.