Fix reportlab GPL issue by removing problematic component #1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
|
Sorry for the indentation / flake 8 error, forgot to check that. Should be fine now |
AndreMiras
approved these changes
Nov 28, 2018
There was a problem hiding this comment.
Thanks for the fixes.
Conditional build fails because of #1485
The rest looks good to me
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the reportlab GPL issue by removing problematic component. (By default, reportlab has a GPL'ed font that is included into the
.apkwhich is quite bad for licensing reasons.)I tested that:
.apk(by manually unzipping it and opening theprivate.mp3tarball)python3crystaxstill workspython3crystaxapp can still successfully export PDF with textSo as far as I'm concerned, this should be ready for merging