Skip to content

Fixes pyleveldb recipe #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2019

Conversation

AndreMiras
Copy link
Member

No description provided.

@AndreMiras AndreMiras requested a review from opacam February 10, 2019 12:23
@AndreMiras
Copy link
Member Author

Travis conditional build happy:

[INFO]:    recipes modified: {'pyleveldb'}
[INFO]:    recipes to build: {'pyleveldb'}
[INFO]:    Found a single valid recipe set: ['hostpython3', 'leveldb', 'libffi', 'openssl', 'snappy', 'sqlite3', 'python3', 'setuptools', 'pyleveldb']
[INFO]:    Trying to find a bootstrap that matches the given recipes.
[INFO]:    Found 3 acceptable bootstraps: ['webview', 'service_only', 'sdl2']
[INFO]:    Using the first of these: webview
[INFO]:    Found a single valid recipe set: ['hostpython3', 'libffi', 'openssl', 'snappy', 'sqlite3', 'leveldb', 'python3', 'genericndkbuild', 'setuptools', 'six', 'pyjnius', 'pyleveldb', 'android']
[INFO]:    recipes to build (no broken): {'pyleveldb'}
[INFO]:    requirements: pyleveldb,python3
...
...

�[1m[INFO]�[0m:    # APK renamed to bdisttest_python3_googlendk-1.1-debug.apk

stty: 'standard input': Inappropriate ioctl for device

�[1m[INFO]�[0m:    �[90m->�[0m running cp /home/user/.local/share/python-for-android/dist...(and 133 more)�[0m

travis_time:end:252e9bd1:start=1549801878908307621,finish=1549802386659226146,duration=507750918525
�[0K�[32;1mThe command "docker run p4a /bin/sh -c "$COMMAND"" exited with 0.�[0m

Done. Your build exited with 0.

See https://travis-ci.org/kivy/python-for-android/jobs/491224312 for detailed build log

Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I like it 😄, also seems that travis is happy so...
¡¡¡Thanks @AndreMiras!!!

@AndreMiras AndreMiras merged commit 059da7b into kivy:master Feb 10, 2019
@AndreMiras AndreMiras deleted the feature/fix_pyleveldb_recipe branch February 10, 2019 12:52


class PyLevelDBRecipe(CompiledComponentsPythonRecipe):
class PyLevelDBRecipe(CppCompiledComponentsPythonRecipe):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note: That is my biggest concern, because we make dependant of gnustl_shared (which, as far as I know, is Deprecated in ndk r18)...so all recipes that depend on gnustl_shared will fail with newer ndks...but ,we have all relevant code concentrated in CppCompiledComponentsPythonRecipe 😉

Related to: Support for NDK 19 (#1613)
See also: https://developer.android.com/ndk/guides/cpp-support

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants