Skip to content

When bootstraps were unified, sources moved from src to src/main/java… #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2020

Conversation

kollivier
Copy link
Contributor

@kollivier kollivier commented Apr 25, 2020

… for webview and service boostraps, so copy self.ctx.javaclass_dir sources there as well.

This is needed for jnius, as it adds org.jnius.NativeInvocationHandler to self.ctx.javaclass_dir, but currently those sources get copied to the old root dir, src, rather than the current src/main/java, which causes jnius to be unable to find that file.

… for webview and service boostraps, so copy other sources there as well.
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, love the small PR addressing a single concern.
And I can't wait for our CI to also catch theses type of regressions

@AndreMiras AndreMiras merged commit 088077f into kivy:develop Apr 25, 2020
@AndreMiras AndreMiras deleted the jnius_fix branch April 25, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants