Skip to content

fix webview jni #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 28, 2020
Merged

fix webview jni #2340

merged 3 commits into from
Dec 28, 2020

Conversation

obfusk
Copy link
Contributor

@obfusk obfusk commented Oct 20, 2020 •
edited
Loading

Fixes #2325.

  • This fixes the dlopen error (and allows use of the android module).
  • request_permissions seems to work (w/ pyjnius 1.2.1 but not yet with 1.3.0).
  • For now I copy-pasted the permissions stuff from the sdl2 bootstrap. I'd prefer refactoring that into a common base class, but I'd require some maintainer input on how they prefer to do that :)

@obfusk obfusk changed the title Fix webview jni fix webview jni Oct 20, 2020
@obfusk obfusk marked this pull request as ready for review October 20, 2020 14:02
@obfusk obfusk mentioned this pull request Oct 20, 2020
Closed
5 tasks
AndreMiras
AndreMiras approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
Regarding refactoring/sharing code between the bootstrap, that's still an open topic and we're also open to suggestions

@AndreMiras AndreMiras merged commit fd4bbec into kivy:develop Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webview app crashes when trying to request permissions
2 participants
@obfusk @AndreMiras