Skip to content

tflite-runtime recipe #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 3, 2022
Merged

tflite-runtime recipe #2554

merged 11 commits into from
Mar 3, 2022

Conversation

RobertFlatt
Copy link
Contributor

@RobertFlatt RobertFlatt commented Mar 3, 2022

Also includes pybind11 recipe.

An example using this recipe and some documentation is here: https://github.com/Android-for-Python/c4k_tflite_example , this link also referenced in tflite-runtime/__init__.py

This recipe does not build on x86_64 so in this case the build runs but creates nothing, enabling ci testing (I hope). This is documented in tflite-runtime/__init__.py . Though this is not ideal, it is solely an emulator case and x86 is presumably a substitute.

The platform build dependency occurs because tflite implementation varies by platform. So a "tflite python api" for x86_64 may compile for some platform, but not another. The Android platform "tflite python api" depends on the RUY matrix multiplication library which does not currently compile for x86_64.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we simply need to get the version right, it shouldn't include the "v"

Comment on lines 7 to 8
version = 'v2.9.0'
url = 'https://github.com/pybind/pybind11/archive/refs/tags/{version}.zip'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = 'v2.9.0'
url = 'https://github.com/pybind/pybind11/archive/refs/tags/{version}.zip'
version = '2.9.0'
url = 'https://github.com/pybind/pybind11/archive/refs/tags/v{version}.zip'

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, thanks

@AndreMiras AndreMiras merged commit d6cf8ec into kivy:develop Mar 3, 2022
@RobertFlatt
Copy link
Contributor Author

Thank you. Example now has local tflite recipe and its reference removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants