Support for display-cutout #2766
Conversation
|
Still one problem. That's when full screen is set. Pre-compiled versions can be found here: display-cutout |
|
Managed to clear out the problems with fullscreen. |
|
Can you help me with the commands? |
|
@misl6 Ping! |
doc/source/buildoptions.rst
Outdated
| ``--display-cutout``: Enables the display cutout (notch) functionality. | ||
| `Android documentation <https://developer.android.com/develop/ui/views/layout/display-cutout>`__. |
There was a problem hiding this comment.
Hi @kuzeyron !
Maybe we can better explain that --display-cutout expects one of the supported display cutout methods as referenced in the Android documentation?
From the current explanation, it may look like that is a boolean flag.
| {% if support_cutout %} | ||
| android:theme="@style/BaseStyle" | ||
| {% endif %} |
There was a problem hiding this comment.
android:theme may be supported even if the device has no support for display-cutouts, and we will likely want to apply that feature to all the supported bootstraps.
Maybe, instead of @style/BaseStyle, we can rename it to @style/KivyManagedStyle ?
| "support_cutout": all([android_api >= 28, | ||
| args.display_cutout != 'never']) |
There was a problem hiding this comment.
Maybe support_cutout should only contain the feature availability, and instead the display_cutout != 'never' check should be done separately?
|
If anyone knows the way around |
This PR enables the display-cutout functionality for python-for-android.